Add building and container recipes#34
Closed
HenryCai-st wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Closed
Add building and container recipes#34HenryCai-st wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
HenryCai-st wants to merge 1 commit intoSimulation-Software-Engineering:mainfrom
Conversation
MakisH
reviewed
Apr 11, 2026
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
Generally, and apart from the late submission, the code looks fine. The Dockerfile and the CMakeLists.txt could be a bit more streamlined, but it already works as-is.
Comment on lines
+16
to
+17
| # change the encoding of shell to remove '\r' | ||
| RUN sed -i 's/\r$//' build_and_run.sh |
There was a problem hiding this comment.
Strange to see this, especially both in the Dockerfile and in the build_and_run.sh.
Comment on lines
+3
to
+9
| # apt-get installs basics | ||
| RUN apt-get update | ||
| RUN apt-get install build-essential cmake unzip wget vim -y | ||
| # boost | ||
| RUN apt-get install libboost-all-dev -y | ||
| # deal II | ||
| RUN apt-get install libdeal.ii-dev -y |
There was a problem hiding this comment.
I would combine these into one RUN command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gitlab name: caihy
verify with
Sorry for the late upload, was caused by Internet Issues